fix(uniq): update example to cover Internet Explorer #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarnball
changed the title
stevemao
requested changes
Nov 30, 2018
stevemao
reviewed
Nov 30, 2018
README.md
Outdated
| * Please note that, the examples used below are just showing you the native alternative of performing certain tasks. For some of the functions, Lodash provides you more options than native built-ins. This list is not a 1:1 comparison. | ||
|
|
||
| * Please send a PR if you want to add or modify the code. No need to open an issue unless it's something big and you want to discuss. | ||
| **Please note that, the examples used below are just showing you the native alternative of performing certain tasks. For some of the functions, Lodash provides you more options than native built-ins. This list is not a 1:1 comparison. |
There was a problem hiding this comment.
@yarnball please check this review comments 😄
stevemao
reviewed
Nov 30, 2018
| @@ -198,7 +198,7 @@ | |||
| }, | |||
| "uniq": { | |||
| "compatible": true, | |||
| "alternative": "[... new Set(arr)]", | |||
| "alternative": "Array.prototype.filter((v, i, a) => a.indexOf(v) === i)", | |||
There was a problem hiding this comment.
Why? this guide is not only for IE. Supporting IE is nice to have
There was a problem hiding this comment.
still hasn't actually been changed after review requested
stevemao
reviewed
Nov 30, 2018
README.md
Outdated
| console.log(result) | ||
| // output: [1, 2, 4, 3] | ||
| // output: [1, 2, 3, 4] |
There was a problem hiding this comment.
Don't change the original. Add a new one and comment "For IE"
cht8687
requested changes
Aug 9, 2019
README.md
Outdated
| * Please note that, the examples used below are just showing you the native alternative of performing certain tasks. For some of the functions, Lodash provides you more options than native built-ins. This list is not a 1:1 comparison. | ||
|
|
||
| * Please send a PR if you want to add or modify the code. No need to open an issue unless it's something big and you want to discuss. | ||
| **Please note that, the examples used below are just showing you the native alternative of performing certain tasks. For some of the functions, Lodash provides you more options than native built-ins. This list is not a 1:1 comparison. |
There was a problem hiding this comment.
@yarnball please check this review comments 😄
GeorgeWL
reviewed
Oct 14, 2019
| @@ -198,7 +198,7 @@ | |||
| }, | |||
| "uniq": { | |||
| "compatible": true, | |||
| "alternative": "[... new Set(arr)]", | |||
| "alternative": "Array.prototype.filter((v, i, a) => a.indexOf(v) === i)", | |||
There was a problem hiding this comment.
still hasn't actually been changed after review requested
| @@ -511,11 +611,11 @@ Gets the first element or all but the first element. | |||
| // output [2, 3] | |||
| ``` | |||
|
|
|||
| #### Browser Support | |||
| #### Browser Support for Spread in array literals | |||
|
|
|||
|
|
||
| **[⬆ back to top](#quick-links)** | ||
|
|
||
| ### _.intersection | ||
| Returns an array that is the intersection of all the arrays. Each value in the result is present in each of the arrays. | ||
| ## Collection* |
There was a problem hiding this comment.
If you want to add new methods, do them in a new request.
We try to keep it to one change of method per PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found an issue with
_.uniqand Internet Explorer (IE).IE does not support
new Set(iterable)See screenshot from
mdnbelow:So, I've updated the example to be IE compatible.
to...