Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore)remove rule count, as it often caused merge conflicts #213

Merged
merged 2 commits into from Aug 10, 2019

Conversation

@cht8687
Copy link
Member

commented Aug 9, 2019

Removed this. It sometimes caused merge conflicts which caused extra unnecessary rebase burden.

@cht8687 cht8687 requested review from stevemao, terrierscript and ODudek Aug 9, 2019

@coveralls

This comment has been minimized.

Copy link

commented Aug 9, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 4ed3b18 on feature/remove-rule-count-validate-for-test into a9d3429 on master.

@cht8687 cht8687 requested a review from cylim Aug 10, 2019

@cylim

cylim approved these changes Aug 10, 2019

Copy link
Member

left a comment

I can't be sure what is the assert for.

If we are comparing the available rules with available test cases, we can separate all the tests into different files for the comparison.

I am totally fine with remove this test.

@stevemao stevemao merged commit 5f86119 into master Aug 10, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@stevemao stevemao deleted the feature/remove-rule-count-validate-for-test branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.