Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore)remove rule count, as it often caused merge conflicts #213

Merged
merged 2 commits into from Aug 10, 2019
Merged

(chore)remove rule count, as it often caused merge conflicts #213

merged 2 commits into from Aug 10, 2019

Conversation

cht8687
Copy link
Member

@cht8687 cht8687 commented Aug 9, 2019

Removed this. It sometimes caused merge conflicts which caused extra unnecessary rebase burden.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4ed3b18 on feature/remove-rule-count-validate-for-test into a9d3429 on master.

@cht8687 cht8687 requested a review from cylim August 10, 2019 03:29
cylim
cylim approved these changes Aug 10, 2019
View reviewed changes
Copy link
Member

@cylim cylim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't be sure what is the assert for.

If we are comparing the available rules with available test cases, we can separate all the tests into different files for the comparison.

I am totally fine with remove this test.

@stevemao stevemao merged commit 5f86119 into master Aug 10, 2019
@stevemao stevemao deleted the feature/remove-rule-count-validate-for-test branch August 10, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cylim cylim cylim approved these changes

@stevemao stevemao stevemao approved these changes

@terrierscript terrierscript Awaiting requested review from terrierscript

@ODudek ODudek Awaiting requested review from ODudek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cht8687 @coveralls @cylim @stevemao