Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add native get/setWeek #49

Merged
merged 3 commits into from Oct 7, 2018
Merged

add native get/setWeek #49

merged 3 commits into from Oct 7, 2018

Conversation

atk
Copy link

@atk atk commented Oct 4, 2018

I wrote a native version of get/setWeek (actually, I copied them over from an old calendar project). I hope you like them.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 135

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 43
Relevant Lines: 43

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 43
Relevant Lines: 43

💛 - Coveralls

Copy link
Member

@ODudek ODudek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments :)

__tests__/index.js Outdated Show resolved Hide resolved
__tests__/performance.js Show resolved Hide resolved
__tests__/performance.js Outdated Show resolved Hide resolved
__tests__/index.js Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ODudek ODudek assigned atk and unassigned atk Oct 4, 2018
@atk
Copy link
Author

atk commented Oct 4, 2018

thanks for your comments.

README.md Show resolved Hide resolved
__tests__/performance.js Outdated Show resolved Hide resolved
@ODudek
Copy link
Member

ODudek commented Oct 7, 2018

Please merge with master to pass tests :)

@stevemao
Copy link
Member

stevemao commented Oct 7, 2018

@ODudek I have restarted the tests against the latest master + this PR and it's green now.

@ODudek ODudek merged commit aa1be55 into you-dont-need:master Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants