Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YSHOP2-1016: EditableStatus takes in labelColor but doesn't use it #151

Merged
merged 4 commits into from
Nov 13, 2023
Merged

YSHOP2-1016: EditableStatus takes in labelColor but doesn't use it #151

merged 4 commits into from
Nov 13, 2023

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Nov 13, 2023 •
edited by jira bot
Loading

JIRA Ticket

YSHOP2-1016

QA Steps

  • Go to http://localhost:3000/
  • The color of both text and the caret of the selected item should comply with what's passed in as props

@eihabkhan1 eihabkhan1 added the 💻 Ready for review Requires a review from another developer. label Nov 13, 2023
@eihabkhan1 eihabkhan1 self-assigned this Nov 13, 2023
@eihabkhan1 eihabkhan1 added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Nov 13, 2023
@eihabkhan1 eihabkhan1 merged commit 18260f7 into main Nov 13, 2023
@eihabkhan1 eihabkhan1 deleted the YSHOP2-1016 branch November 13, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosarabi mosarabi mosarabi approved these changes

@AliHMIMS AliHMIMS Awaiting requested review from AliHMIMS

Assignees

@eihabkhan1 eihabkhan1

Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eihabkhan1 @mosarabi