YSHOP2-1137-v2 : Rich text editor with froala #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhitaNektt
requested review from
AliHMIMS,
mosarabi and
eihabkhan1
as code owners
-m "Merged main to resolve conflicts"
-m "Merged main to update branch"
-m "Merged main to update branch"
-m "Merged main to resolve conflicts"
GhitaNektt
added
💻 Ready for review
added 2 commits
January 25, 2024 15:22
eihabkhan1
reviewed
Jan 25, 2024
packages/vue3/src/_dev/App.vue
Outdated
| </div> | ||
| </template> | ||
|
|
||
| <style scoped> | ||
| <style scoped lang="css"> |
There was a problem hiding this comment.
css is the default lang so we can omit this
Suggested change
| <style scoped lang="css"> | |
| <style scoped> |
added 3 commits
January 25, 2024 15:51
-m "Resolved conflicts"
GhitaNektt
removed
the
💻 Ready for review
added 6 commits
January 29, 2024 10:46
-m "resolved pnpm file conflicts"
-m "merged main to resolve conflicts"
GhitaNektt
added
💻 Ready for review
|
Seems like we have a responsitivty issue: Screen.Recording.2024-01-29.at.2.54.23.PM.mov |
added 3 commits
January 29, 2024 15:19
-m "Merged main to resolve conflict"
eihabkhan1
approved these changes
Feb 1, 2024
eihabkhan1
added
✅ Reviewed
-m "Merged main branch to resolve conflicts"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
YSHOP2-1137
QA Steps
Note
Leave empty when you have nothing to say