UI-274: SettingsNav > Improvement #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosarabi
requested review from
AliHMIMS,
eihabkhan1 and
GhitaNektt
as code owners
|
I noticed that in RTL the active element bar in brand color should be on the right 
Also the in the settings nav item there is a style applied directly to button element if you can add more specificity to that it would be great. |
GhitaNektt
added
🛠 Requested changes
mosarabi
added
💻 Ready for review
GhitaNektt
approved these changes
Mar 13, 2024
GhitaNektt
added
✅ Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
UI-274
QA Steps
Note
Leave empty when you have nothing to say