Failback to sandbox only on specific status #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.10%@@ master #26 diff @@
==========================================
Files 8 8
Lines 320 321 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 285 286 +1
Misses 35 35
Partials 0 0
|
| @@ -89,7 +90,8 @@ def verify(self, **options): | |||
| try: | |||
| response = self.verify_from(RECEIPT_PRODUCTION_VALIDATION_URL, verify_ssl) | |||
| except exceptions.InvalidReceipt: | |||
| if not use_sandbox: | |||
| if not use_sandbox and (response is None or | |||
There was a problem hiding this comment.
response will be always None in this case. So this patch doesn't fix the behavior of the code. (Because it is always True)
Instead of it, InvalidReceipt will have a property status. So how about to try:
if not use_sandbox and e.status != STATUS_SANDBOX_RECEIPT_ERROR:
|
Travis will test it when you make a PR :) Thanks for a nice patch. |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to iTunes documentation, their production API will return specific status in case when we are sending transaction raw data from their sandbox's environment:
https://developer.apple.com/library/ios/technotes/tn2413/_index.html#//apple_ref/doc/uid/DTS40016228-CH1-RECEIPTURL
Hence, we do not need to send any other failed transactions (those which returned status other than 21007) to sandbox in case when both production and sandbox environments are used.
Note: while testing on my machine (excluding py2.6, 3.3 and pypi) I got FAIL for py27 in test_receipt, line
assert isinstance(in_app0.original_purchase_date_ms, int)- 1432002585000L is not an int (if applicable, I'm using 32bit OS).