Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

by-AttributeError/KeyError-catchable ObjectMapper attribute misses #27

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

yoloseem
Copy link
Contributor

@yoloseem yoloseem commented Jun 29, 2016

Motivation:

  • KeyError from attribute access is unexpectable.

Changes:

  • Raise other exception could be caught by AttributeError, rather than KeyError.
  • To prevent unintended breaking on codes may be using KeyError to catch that cases, created MissingFieldError inherited both AttributeError and KeyError.

@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage increased (+0.5%) to 89.602% when pulling feb9a90 on yoloseem:attrmiss into 45a9cae on youknowone:master.

@codecov-io
Copy link

codecov-io commented Jun 29, 2016

Current coverage is 89.60%

Merging #27 into master will increase coverage by 0.51%

@@             master        #27   diff @@
==========================================
  Files             8          8          
  Lines           321        327     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            286        293     +7   
+ Misses           35         34     -1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 45a9cae...feb9a90

To prevent any unintended incompatibility with codes may be using
KeyError to catch that cases, created MissingFieldError inherited
both AttributeError and KeyError.
@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage increased (+0.2%) to 89.297% when pulling f6a3908 on yoloseem:attrmiss into 45a9cae on youknowone:master.

@youknowone youknowone merged commit 0e615e4 into youknowone:master Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants