Add aioredis tests for both client/pool #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #110 |
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 14 14
Lines 1387 1387
=======================================
Hits 1359 1359
Misses 28 28 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 14 14
Lines 1387 1387
=======================================
Hits 1359 1359
Misses 28 28 |
youknowone
requested changes
Jun 29, 2019
rscarrera27
added a commit
to rscarrera27/ring
that referenced
this pull request
Jun 29, 2019
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now ring's tests only test with aioredis's connection pool, so modify the test to use both aioredis connection and connection pool.
Added aioredis connection fixture with the same interface as aioredis pool fixture
Modified tests to use both pool and connection
Fix aiomcache/aioredis tests for both client/pool #110