Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDWebImage singleton usage #83

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Fix SDWebImage singleton usage #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279b85a
correct SDWebImage singleton instance usage
atulkhatri Jun 20, 2020
48ee5b5
correct SDWebImage singleton instance usage
atulkhatri Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MediaBrowser/Media.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ open class Media: NSObject {

// Load from local file
private func performLoadUnderlyingImageAndNotifyWithWebURL(url: URL) {
operation = SDWebImageManager.shared().loadImage(with: url, options: [], progress: { (receivedSize, expectedSize, targetURL) in
operation = SDWebImageManager.shared.loadImage(with: url, options: [], progress: { (receivedSize, expectedSize, targetURL) in
let dict = [
"progress" : min(1.0, CGFloat(receivedSize)/CGFloat(expectedSize)),
"photo" : self
Expand Down
2 changes: 1 addition & 1 deletion MediaBrowser/MediaBrowser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ func floorcgf(x: CGFloat) -> CGFloat {
pagingScrollView.delegate = nil
NotificationCenter.default.removeObserver(self)
releaseAllUnderlyingPhotos(preserveCurrent: false)
SDImageCache.shared().clearMemory() // clear memory
SDImageCache.shared.clearMemory() // clear memory
}

private func releaseAllUnderlyingPhotos(preserveCurrent: Bool) {
Expand Down