Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger, onValueChanged and comment issue #5

Closed
Jamalianpour opened this issue Mar 30, 2022 · 1 comment
Closed

Logger, onValueChanged and comment issue #5

Jamalianpour opened this issue Mar 30, 2022 · 1 comment
Labels
bug Something isn't working fixed

Comments

@Jamalianpour
Copy link

Hello, at the first I should say thanks for your awesome repo
Anyway I have some issue with that

  1. Why did you use logger package for validating data this is very annoying. Please add an options to disable that

image

  1. There is some delay to update value in onValueChanged
    for example I write this json and after that immediately press a button:
    image
    but I get this json as JsonElement:
{
    "test": ""
}
  1. When I try to add jsonString with a comment the comment does not display:
JsonEditor.string(
  jsonString: '''
  {
      // Insert your data here
  }
  ''',
  enabled: true,
  onValueChanged: (value) {
    document = value;
  },
),
youngchan1988 pushed a commit that referenced this issue Mar 31, 2022
@youngchan1988 youngchan1988 added bug Something isn't working fixed labels Mar 31, 2022
@youngchan1988
Copy link
Owner

Hi there! Thanks a lot for your suggestion. I have optimized the code in 0.0.6. About 2, onValueChanged called behind the analysis. So there is a delay to make sure the result is correct. You can have a try again. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

2 participants