Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some remarks about your repository #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ymartin59
Copy link

@youngde811 I am interested in your initiative. But I find your own Git history is not really clean...

  • many commits with two different authors => please fix your local Git author configuration for your commits to match GitHub identity
  • for the very "same change" (Converting source files to new project names) => you should have rebase/squash them
  • and useless "merge commits" => you should create Pull Request and use "rebase" merge mode.

It is still time to refactor commit history before it gets more visibility.

I also wonder where Java package "com.madgag" comes from, and it may be relevant to change it too.

Your repository has not "Issues" enabled yet (please got to repository Settings and check it)... that is why I propose improvements here.

@sgrayban
Copy link

Error building...

[error] gitclean/gitclean-library/src/main/scala/com/madgag/git/gitclean/model/Commit.scala:91:36: value toStream is not a member of java.util.stream.Stream[String]
[error] lazy val subject = message.lines.toStream.headOption
[error] ^
[error] gitclean/gitclean-library/src/main/scala/com/madgag/git/gitclean/model/Commit.scala:94:83: missing parameter type for expanded function
[error] The argument types of an anonymous function must be fully known. (SLS 8.5)
[error] Expected type was: java.util.stream.Collector[? >: String, ?, ?]
[error] lazy val footers: List[Footer] = message.drop(lastParagraphBreak).lines.collect {
[error] ^
[error] two errors found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants