Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] modify staleTime, gcTime #136

Open
Hanna922 opened this issue Apr 11, 2024 · 4 comments
Open

[REFACTOR] modify staleTime, gcTime #136

Hanna922 opened this issue Apr 11, 2024 · 4 comments
Assignees
Labels

Comments

@Hanna922
Copy link
Member

ISSUE โœ… : REFACTOR

๐Ÿ“– DESCRIPTION

๊ฐ useQuery์—์„œ ๋ณ„๋„ ์„ค์ •ํ•ด์ฃผ๋˜ ๊ฐ’์„ ์‚ญ์ œํ•˜๊ณ , QueryClient๋กœ ๊ถŒ์žฅ ๊ฐ’์„ ๋„ฃ์–ด์ฃผ๋ ค ํ•ฉ๋‹ˆ๋‹ค.
#129 ๋จธ์ง€๋˜๋ฉด ์ž‘์—… ํ•  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค.

Infinity๋กœ ์„ค์ •๋œ ์‹ค์‹œ๊ฐ„ ๊ฒ€์ƒ‰์–ด ๋ถ€๋ถ„์€ ์–ด๋–ป๊ฒŒ ํ• ์ง€ ์ข€ ๋” ๊ณ ๋ฏผํ•ด๋ณผ๊ฒŒ์šฉ

@Hanna922 Hanna922 self-assigned this Apr 11, 2024
@2wndrhs
Copy link
Member

2wndrhs commented Apr 12, 2024

tankstack query ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์—์„œ staleTime์˜ ๊ธฐ๋ณธ๊ฐ’์€ 0, gcTime์˜ ๊ธฐ๋ณธ๊ฐ’์€ 5๋ถ„์œผ๋กœ ์„ค์ •ํ•ด์ฃผ๊ณ  ์žˆ๋˜๋ฐ statleTime, gcTime์„ ๋”ฐ๋กœ ์ˆ˜์ •ํ•  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”?

@Hanna922
Copy link
Member Author

Hanna922 commented Apr 12, 2024

tankstack query ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์—์„œ staleTime์˜ ๊ธฐ๋ณธ๊ฐ’์€ 0, gcTime์˜ ๊ธฐ๋ณธ๊ฐ’์€ 5๋ถ„์œผ๋กœ ์„ค์ •ํ•ด์ฃผ๊ณ  ์žˆ๋˜๋ฐ statleTime, gcTime์„ ๋”ฐ๋กœ ์ˆ˜์ •ํ•  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”?

staleTime = 0์ธ๊ฒŒ ์‚ฌ์‹ค์ƒ ์บ์‹ฑ ํšจ๊ณผ๋ฅผ ๋ชป ๋ณด๊ณ  ์žˆ๋Š” ๊ฑฐ๋‚˜ ๋งˆ์ฐฌ๊ฐ€์ง€๋ผ TKDodo ๊ฐœ์ธ ๋ธ”๋กœ๊ทธ์—์„œ ์ œ์‹œํ•˜๋Š” ์ถ”์ฒœ ํƒ€์ž„ ์ตœ์†Œ 20์ดˆ ์ •๋„๋ฅผ ์ค„๊นŒ ์ƒ๊ฐ ์ค‘์ž…๋‹ˆ๋‹ค. Soomsil ์„œ๋ฒ„ ๋ฐ์ดํ„ฐ๊ฐ€ ์ •๋ง ์ž์ฃผ ๋ฐ”๋€Œ๋Š” ์„œ๋น„์Šค๊ฐ€ ์•„๋‹ˆ๊ธฐ ๋•Œ๋ฌธ์—, ๊ธฐ๋ณธ ๊ฐ’์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ๋ณด๋‹ค ์ข‹์ง€ ์•Š์„๊นŒ ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.
(+ ํ•ด๋‹น ์ด์Šˆ์—์„œ ๊ฐ useQuery์— ์„ค์ •ํ•ด ๋‘” staleTime, gcTime์€ ํ•„์ˆ˜์ ์ธ ๊ฒŒ ์•„๋‹ˆ๋ผ๋ฉด ๋ชจ๋‘ ์‚ญ์ œํ•  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค.)

@2wndrhs
Copy link
Member

2wndrhs commented Apr 12, 2024

ํ•ด๋‹น ๊ธ€์—์„œ ๋„๋„์”จ๊ฐ€ ๋™์ผํ•œ ๋ Œ๋”๋ง ์ฃผ๊ธฐ๊ฐ€ ์•„๋‹Œ ์—ฐ์†์œผ๋กœ ๊ฐ™์€ ์ฟผ๋ฆฌ๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ์ปดํฌ๋„ŒํŠธ๊ฐ€ ๋งˆ์šดํŠธ๋  ๋•Œ๋ฅผ ๋ฌธ์ œ ์ƒํ™ฉ์œผ๋กœ ์–ธ๊ธ‰ํ•˜๋Š”๋ฐ(์•„๋ž˜ ์ฝ”๋“œ์ฒ˜๋Ÿผ) ํ˜„์žฌ ์ˆจ์‰ด๋•Œ ์„œ๋น„์Šค์— ํ•ด๋‹น ๋ฌธ์ œ ์ƒํ™ฉ์ด ๋ฐœ์ƒํ•˜๊ณ  ์žˆ๋Š”์ง€ ์˜๋ฌธ์ž…๋‹ˆ๋‹ค.

function ComponentOne() {
  const { data } = useTodos()

  if (data) {
    // โš ๏ธ mounts conditionally, only after we already have data
    return <ComponentTwo />
  }
  return <Loading />
}

function ComponentTwo() {
  // โš ๏ธ will thus trigger a second network request
  const { data } = useTodos()
}

const queryClient = new QueryClient()

function App() {
  return (
    <QueryClientProvider client={queryClient}>
      <ComponentOne />
    </QueryClientProvider>
  )
}

YAGNI (์ •๋ง ํ•„์š”ํ•˜๋‹ค๊ณ  ๊ฐ„์ฃผํ• ๋•Œ๊นŒ์ง€ ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜์ง€๋งˆ๋ผ) ์›์น™์— ๋”ฐ๋ผ์„œ ๊ฐ™์€ ๋ฐ์ดํ„ฐ๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ์ปดํฌ๋„ŒํŠธ๊ฐ€ ์ค‘๋ณต๋œ ๋„คํŠธ์›Œํฌ ์š”์ฒญ์„ ๋ณด๋‚ด๋Š” ๋ฌธ์ œ ์ƒํ™ฉ์ด ๋ฐœ์ƒํ•  ๋•Œ ํ•ด๋‹น ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜๋Š”๊ฒŒ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”

@Hanna922
Copy link
Member Author

์˜คํ˜ธ๋ผ. ์„œ๋ฒ„ ๋ฐ์ดํ„ฐ๊ฐ€ ์ž์ฃผ ๋ฐ”๋€Œ๋Š” ์„œ๋น„์Šค๊ฐ€ ์•„๋‹ˆ๋ผ๊ณ  ์ƒ๊ฐํ–ˆ๊ธฐ ๋•Œ๋ฌธ์— ํ•ด๋‹น ์ƒํ™ฉ์€ ๋ฌผ๋ก ์ด๊ณ  ๊ธฐ์กด ๊ฐ’๋„ ๋ช‡ ์ดˆ ์ •๋„๋ฅผ ์ฃผ๋ฉด ์ข‹์ง€ ์•Š์„๊นŒ ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค. ํ•ด๋‹น ์›์น™์„ ์šฐ์„ ์œผ๋กœ ์ƒ๊ฐํ•˜์‹ ๋‹ค๋ฉด ์ถ”ํ›„ ์บ์‹ฑ์ด ํ•„์š”ํ•ด์ง„ ํŠน์ • useQuery๋งŒ ์„ค์ •ํ•ด์ฃผ๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™๋„ค์š”
์œผ์Œ ์ผ๋‹จ ์„ค์ •๋˜์–ด์žˆ๋˜ ๊ฐ’๋“ค์€ ์ „๋ถ€ ์‚ญ์ œํ•˜๊ณ  ์ข€ ๋” ๊ณ ๋ฏผํ•ด๋ณผ๊ฒŒ์š”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants