refactor: Toast z-index 지정 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanna922
approved these changes
May 16, 2024
|
제발아니라고해주세요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
버그 픽스
z-index가 1 이상인 요소 (토마토색 박스) 가 존재하는 페이지에서 토스트 사용하면 토스트가 깔림
(테스트만 하려고 잠시 스토리 수정한 겁니다!! 실제로는 토마토박스 업성요)
2️⃣ 알아두시면 좋아요!
화면 전체를 감싸는
StyledToastWrapper에 z-index를 줘도 ㄱㅊ은 이유: pointer-events: none; 가 있기 때문에 토스트 뜨고 있어도 다른 요소의 이벤트가 씹히지 않음4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?