Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StyledSearchPrefixContainer rendering when searchPrefix is not present #105

Merged
merged 2 commits into from
May 20, 2024

Conversation

nijuy
Copy link
Collaborator

@nijuy nijuy commented May 16, 2024

1️⃣ 어떤 작업을 했나요? (Summary)

버그 픽스

<StyledTextFieldWrapper>
  <StyledSearchPrefixContainer>{searchPrefix}</StyledSearchPrefixContainer>
</StyledTextFieldWrapper>

searchPrefix prop 존재 유무를 판단하지 않고 있어서 searchPrefix가 없는 SimpleTextField에도 빈 div가 생기는 중 (보라)

image

StyledSearchPrefixContainer를 삭제해서 searchPrefix prop가 없을 때는 안 그림

image

단, StyledSearchPrefixContainer를 삭제하면 아이콘 크기가 보장되지 않는 문제가 재발함

이 문제는 StyledTextFieldWrapper 내부 svg에 flex-shrink: 0을 지정하는 방법으로 해결함

4️⃣ 체크리스트 (Checklist)

  • main 브랜치의 최신 코드를 pull 받았나요?

nijuy added 2 commits May 16, 2024 23:30
- 내부 svg는 searchPrefix, suffix에 Icon이 들어가는 경우
- size 보장을 위해 설정
@nijuy nijuy added bug Something isn't working fix labels May 16, 2024
@nijuy nijuy self-assigned this May 16, 2024
@nijuy nijuy requested a review from Hanna922 as a code owner May 16, 2024 14:39
Copy link
Member

@Hanna922 Hanna922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ദ്ദി -᷄ ᴗ -᷅ )
역시 성급한 버전업은 이런 현상을..

@Hanna922 Hanna922 changed the title fix: searchPrefix가 없을 때도 StyledSearchPrefixContainer가 렌더링 되는 문제 fix: StyledSearchPrefixContainer rendering when searchPrefix is not present May 20, 2024
@nijuy nijuy merged commit b5e7e2a into develop May 20, 2024
1 check passed
@nijuy nijuy deleted the fix/#104-searchprefix-div branch May 20, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: searchPrefix가 없을 때도 StyledSearchPrefixContainer가 렌더링 되는 문제
2 participants