Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply forwardRef in TextField #109

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

Hanna922
Copy link
Member

1️⃣ 어떤 작업을 했나요? (Summary)

기존 코드에 영향을 미치는 변경사항

모든 TextField에 ref를 전달할 수 있도록 forwardRef로 감쌉니다

3️⃣ 추후 작업

숨쉴 적용을 위해 머지 후 버전 업 하겠습니다

4️⃣ 체크리스트 (Checklist)

  • main 브랜치의 최신 코드를 pull 받았나요?

@Hanna922 Hanna922 added the feat label May 23, 2024
@Hanna922 Hanna922 self-assigned this May 23, 2024
@Hanna922 Hanna922 requested a review from nijuy as a code owner May 23, 2024 02:59
@Hanna922 Hanna922 requested a review from fecapark May 23, 2024 03:01
@Hanna922
Copy link
Member Author

Hanna922 commented May 23, 2024

@fecapark feca도 원하신 수정사항이 맞는지 한 번 확인 부탁드려용

Copy link
Collaborator

@nijuy nijuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인해씁니다
displayName이 어디엔 있고 어디엔 없는데 일괄 적용해야 할 거 같아요

@Hanna922 Hanna922 requested a review from nijuy May 23, 2024 07:23
Copy link
Contributor

@fecapark fecapark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !!

@Hanna922 Hanna922 merged commit 6ca62b7 into develop May 23, 2024
@Hanna922 Hanna922 deleted the feat/#108-forwardRef-TextField branch May 23, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add ref property to TextField component
3 participants