fix: storybook missing controls props #78
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
2️⃣ 알아두시면 좋아요!
union/ReactReactNode type으로 인식되는 부분에 있어 Storybook을 좀 뜯어봤습니다.
Storybookjs next branch에서 local storybook 실행 시
이렇게 뜨고 있고, Storybookjs #19580 보시면 문제점에 "We have many duplicated types in our codebase" 언급 확인하실 수 있습니다.
결론: 수동 문서로 type을 전부 넣어줄 것 아니면 autodocs를 사용하는 이상 간결하게 타입을 표시하게 됨, 스토리북에서 취급하는 예제에서도 union 타입으로 보여줌
4️⃣ 체크리스트 (Checklist)
main
브랜치의 최신 코드를pull
받았나요?