-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 웹에 맞게 Toast.style 수정 #84
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ff3b45b
design: `StyledToastWrapper` `StyledToast` 스타일 수정
nijuy 26212b6
docs: Toast.stories.tsx 수정
nijuy 45de30b
docs: `HookTest` 스토리 수정
nijuy 600d6eb
feat: `width` props 추가 및 문서 수정
nijuy dece921
chore: css 속성 순서 정리
nijuy 1c119e0
docs: 스토리 순서 변경
nijuy ea7244a
fix: (ts -> tsx) HookSource md file extension
Hanna922 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스토리북에서 토스트가 한 번 뜬 이후 다시 나타나지 않는 게 살짝 불편한데, 사용처에 duration 설정을 온전히 맡기고 기본 값은 무한으로 설정해두는 거 어떠신가요?
ToastHook만 duration long 유지하고, SingleLine, MultiLine은 설정하지 않으면 좋을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
내부에 삭제 버튼이 존재하지 않는다는 점에서 YDS의
Toast
는 사용자에게 피드백을 제공한 뒤 자체적으로 사라져야 하는 컴포넌트이고, 이러한 역할을 생각했을 때duration
의 기본값을 무한대로 설정하는 것이 어색하게 느껴집니다. 문서 조회에서 발생한 문제를 컴포넌트 코드의 수정으로 해결하는 것도 적절하지 않다는 생각이 들어요말씀하신 불편함에는 저 역시도 공감합니다! 문서를 좀 다듬어보고 리뷰 요청 다시 넣을게요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
토스트가 생겼다 사라지는 것을 무한으로 반복해도 좋을 것 같네요 (일정 간격을 두고)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 Single Line, Multi Line은 무한 반복이 불가능할까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용자가 원하는 시점에 원하는 옵션으로 다시 조회하는 기능이 낫다고 생각했고, 그 기능은 현재 PrimaryBlock에서 충분히 가능하기 때문에 필요성을 잘 모르겠어서 일단 추가하지 않았습니다