Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ppss.kr #169

Closed
wants to merge 1 commit into from
Closed

Fix ppss.kr #169

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 23, 2021

@ghost ghost closed this Apr 23, 2021
yous added a commit that referenced this pull request Apr 23, 2021
@yous
Copy link
Owner

yous commented Apr 23, 2021

Thank you for the PR, but ##div.wing_banner will block ##div[id^="ppss_wing_banner_"] too.

ppss.kr has ad-shield.io scripts, and they use URLs like https://ppss.kr/539cbc04-8140-43e8-81d6-9febfa2c911d. So I added a regex rule on ee9a8af.

Also, the following rules will block the ads element from ad-shield.io.

  • ppss.kr##main#genesis-content>span:not([class]):not([id]) div
  • ppss.kr##section#custom_html-3

@JobcenterTycoon
Copy link

/^[^:]+:\/\/+([^:/]+\.)?ppss\.kr\/[0-9A-Za-z]+$/$domain=ppss.kr breaks the page

@yous
Copy link
Owner

yous commented Jul 6, 2021

That rule has been removed. Currently this filter doesn't block ad-shield.io advertisements, as they prevent to load images when they detect element hidings.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants