Skip to content

Commit

Permalink
_vimrc.plugins: disable airline for now
Browse files Browse the repository at this point in the history 
Seems like now I have tweaked the configuration to a minimal that serves
no notable real function other than just a slightly more fresh good
looking, yet the lag is just untolerable.  Disable it for now until
vim-airline/vim-airline#1779 is fixed
  • Loading branch information
@yousong
yousong committed Aug 22, 2018
1 parent eb519f6 commit a983c7b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion data/_vimrc.plugins
View file
Expand Up @@ -10,7 +10,7 @@ filetype off "required
set rtp+=$HOME/.vim/bundle/Vundle.vim
call vundle#begin() "call with a path vundle#begin('~/some/path/here')
Plugin 'gmarik/Vundle.vim' "Github username/reponame
Plugin 'bling/vim-airline'
"Plugin 'bling/vim-airline'
Plugin 'tpope/vim-fugitive' " Required by vim-airline for git repo.
Plugin 'terryma/vim-multiple-cursors'
"Plugin 'SirVer/ultisnips' "The engine
Expand Down

8 comments on commit a983c7b

@itsfarseen
Copy link

@itsfarseen itsfarseen commented on a983c7b Sep 26, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does whether ultisnips is enabled affect the lag caused by airline?
It does in my configuration. Could you please confirm?
vim-airline/vim-airline#1802 (comment)

@yousong
Copy link
Owner Author

@yousong yousong commented on a983c7b Sep 26, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@happycoder97 When the said issue in the commit message happened, ultisnips was already commented out. So it's unlikely that the lagness was caused by it. The said issue can be easily reproduced against airline.

@chrisbra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, you did use quite an old version of airline. There have been many enhancements made since then, also performance improvements.

@yousong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisbra Yeah, I just tried the latest master branch, I think the issue is still there.

Here is how I tried to reproduced the issue.

  1. Enable airline
  2. Start vim and open a few files in windows, tabs, view the current content of :echo g:airline#themes#{g:airline_theme}#palette
  3. Close them one by one, and check :echo g:airline#themes#{g:airline_theme}#palette.

The content just kept growing monotonically. Not sure whether this is the expected behavior but I am afraid it will degrade the performance gradually over a time span of editing.

@yousong
Copy link
Owner Author

@yousong yousong commented on a983c7b Sep 26, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw. g:airline_theme is dark. And thank you for your time and efforts on this project. I really appreciate it.

@chrisbra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: I could not reproduce your issue with a monotonic increasing palette. How do you reproduce this?

@yousong
Copy link
Owner Author

@yousong yousong commented on a983c7b Nov 7, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed the lag only gradually over several quite long sessions of coding. The above said reproduce steps were my possibly naive method of checking whether the palette dict was increasing its size unexpectedly.

I will enable airline again and if I can reproduce the issue, I will have the palette dict dump recorded. How do you think the dump will help with the debug?

@chrisbra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it would be interesting to see, what keys accumulate there that have not been there. Perhaps we can make a guess at why they have been added.

Please sign in to comment.