Squashed workflows #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
pushed a commit
that referenced
this pull request
Jul 13, 2024
…ation (cherry picked from commit 1a83160) (cherry picked from commit ee88492) Bug: b/40284908 Change-Id: I64f20ae601028987af1791c757e218e18e0ddd31 Fixed: b/343017102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5575127 Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com> Auto-Submit: Samar Chehade-Lepleux <samarchehade@google.com> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Original-Commit-Position: refs/heads/main@{#1306687} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5575755 Commit-Queue: Menghan Yang <myuu@google.com> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Menghan Yang <myuu@google.com> Cr-Original-Commit-Position: refs/branch-heads/6506@{#4} Cr-Original-Branched-From: 2c488d6-refs/heads/main@{#1306564} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5576974 Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#769} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
kaidokert
pushed a commit
that referenced
this pull request
Jul 13, 2024
This CL adds a quick if to fix the crash. Since I was unable to deduce which content settings type is causing the crash, I've added a metric for investigation. Will revisit the original bug in 1 milestone. (cherry picked from commit be49f04) (cherry picked from commit 78c964a) Bug: 346343332, 351429535 Change-Id: Ibdb4d6f42e9d7287bec454006af61ec0160f1d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5622173 Reviewed-by: Ravjit Uppal <ravjit@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/main@{#1313462} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5621338 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/6533@{#4} Cr-Original-Branched-From: 7e0b87e-refs/heads/main@{#1313161} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5701645 Auto-Submit: Florian Jacky <fjacky@chromium.org> Reviewed-by: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Florian Jacky <fjacky@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#1753} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.