-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up telemetry_test and fix. #3047
Conversation
86a0390
to
dc76165
Compare
I tried this on a Sabrina device and it loaded the app but did not respond to remote keypresses. remote devtools worked, but the |
0c92fc5
to
f5862e3
Compare
b/330355045
f5862e3
to
acc9310
Compare
Updated
|
The failed checks are due to infra issues.
|
Can you explain a little bit what's the original issue with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. There is a lot of long overdue and complex cleanup in here. Thanks!
The New:
Old:
The updated //base implementation simplifies the running of the next task into one call. If there is a delayed task that is ready to be done and and immediate task available, either task might be run in one iteration of the run loop. The
The old //base is different.
If we did work, we should try to pull more work to do now. Another iteration should always be attempted. We did update the MessagePump code to use the new I tried to fix just the issue. But the code as written was difficult to fix without breaking something else. This is what led me to modifying In addition to this, I changed |
Do I need to keep retrying the on_device checks that failed? Are they more flaky than the normal checks (which are also quite flaky)? |
Pull Request is not mergeable
Thanks for the detailed explanation. For the failing the tests, maybe better do some retries once or twice to see if it's just flaky. And you can compare the test result with trunk as well. If it continue fails, maybe take a look if it fails for the same reason. Now, it seems like many Android tests fail. |
b/330355045 The fix includes fixing the starboard implementation of `MessagePump`: `MessagePumpUIStarboard` and `MessagePumpIOStarboard`. (cherry picked from commit a529b2b)
b/330355045 The fix includes fixing the starboard implementation of `MessagePump`: `MessagePumpUIStarboard` and `MessagePumpIOStarboard`. (cherry picked from commit a529b2b)
Refer to the original PR: #3047 b/330355045 The fix includes fixing the starboard implementation of `MessagePump`: `MessagePumpUIStarboard` and `MessagePumpIOStarboard`. Co-authored-by: aee <117306596+aee-google@users.noreply.github.com>
b/330355045
The fix includes fixing the starboard implementation of
MessagePump
:MessagePumpUIStarboard
andMessagePumpIOStarboard
.