Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real DOM for testing #178

Open
rviscomi opened this issue Nov 24, 2014 · 0 comments
Open

Use real DOM for testing #178

rviscomi opened this issue Nov 24, 2014 · 0 comments
Labels
bug

Comments

@rviscomi
Copy link
Member

The resource and response tests rely on a FakeElement object that has its own implementation of DOM methods like appendChild and insertBefore. This is fine for the common case, but edge cases like older version of Internet Explorer may have quirks that are not reflected in the FakeElement implementation. This masks bugs that would otherwise fail the tests.

These tests should instead rely on the native DOM and its methods.
@rviscomi rviscomi added the bug label Nov 24, 2014
rviscomi added a commit to rviscomi/spfjs that referenced this issue Dec 3, 2014
@rviscomi
Use real DOM for testing (1 of 2).
0e76fcf 
New JS library `spf.testing.dom` appends elements to the document to be used in SPF tests.

Use this on response_test. Next and final part is to change resource_test.

Progress on youtube#178
@rviscomi rviscomi mentioned this issue Dec 3, 2014
Merged
rviscomi added a commit to rviscomi/spfjs that referenced this issue Dec 3, 2014
@rviscomi
Use real DOM for testing (1 of 2).
4a27114 
New JS library `spf.testing.dom` appends elements to the document to be used in SPF tests.

Use this on response_test. Next and final part is to change resource_test.

Progress on youtube#178
rviscomi added a commit to rviscomi/spfjs that referenced this issue Jan 7, 2015
@rviscomi
Use real DOM for testing (2 of 2).
0fe4791 
Resources are created in an iframe using real DOM elements as opposed to FakeElements.
el.href would return the canonical URL ("file://foo.bar") so we use el.getAttribute('href') instead ("//foo.bar").

Closes youtube#178
@rviscomi rviscomi mentioned this issue Jan 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use real DOM for testing (2 of 2). rviscomi/spfjs
1 participant
@rviscomi