Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2604 & #2661 解决动态添加tabs列表内容时,顺序错乱以及下划线长度不变的问题。 #2663

Merged
merged 4 commits into from Jan 9, 2020

Conversation

a20086115
Copy link
Contributor

解决动态添加tabs列表内容时,顺序错乱以及下划线长度不变的问题。
Fix #2604 & #2661

Yu wenqiang and others added 2 commits January 9, 2020 18:35
解决动态添加tabs列表内容时,顺序错乱以及下划线长度不变的问题。
this.children.push(target);
// target.index = this.children.length;
// this.children.push(target);
this.children = this._getAllLi();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议命名为 getChildren,并删除注释代码

@rex-zsd rex-zsd merged commit 37a3929 into youzan:dev Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] van-tabs 动态异步添加 tab 时后,tabs下方的高亮线没有更新
3 participants