Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): add new prop dataset #3075

Merged
merged 2 commits into from May 1, 2020

Conversation

rex-zsd
Copy link
Collaborator

@rex-zsd rex-zsd commented Apr 26, 2020

fix #2483

@rex-zsd rex-zsd requested a review from chenjiahan April 26, 2020 09:16
@@ -2,6 +2,7 @@

<button
id="{{ id }}"
data-data="{{ dataset }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个写法有点奇怪

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是想让你参谋参谋这个命名的问题 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要么就改成 dataset.detail。。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

挺不错

@rex-zsd rex-zsd merged commit 7cce96a into youzan:dev May 1, 2020
@rex-zsd rex-zsd added this to the 1.3.0 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] open-type属性为share的button点击后回调值内的dataset为空
2 participants