We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collapse
https://vant-ui.github.io/vant/#/en-US/collapse
4.8.0
The translation of the example in collapseis inconsistent, and I'm not sure if it needs to be modified.
No response
The text was updated successfully, but these errors were encountered:
you can update that~ be consistent is better
Sorry, something went wrong.
I am happy to make it better. I found that showDialog also has the same issue. Is it fixed on a new PR or this this PR?
showDialog
There is this sample code on showDialog:
const beforeClose = (action) => new Promise((resolve) => { setTimeout(() => { resolve(action === 'confirm'); }, 1000); });
const beforeClose = (action) => new Promise((resolve) => { setTimeout(() => { if (action === 'confirm') { resolve(true); } else { // 拦截取消操作 resolve(false); } }, 1000); });
Their results are consistent, but which writing method should I follow?
I will divide it into two submissions to facilitate the marking of ci tags(i think).
Successfully merging a pull request may close this issue.
重现链接
https://vant-ui.github.io/vant/#/en-US/collapse
Vant 版本
4.8.0
描述一下你遇到的问题。
The translation of the example in
collapse
is inconsistent, and I'm not sure if it needs to be modified.重现步骤
设备/浏览器
No response
The text was updated successfully, but these errors were encountered: