Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]docs : Inconsistent translation of examples incollapse #12463

Closed
RSS1102 opened this issue Nov 22, 2023 · 3 comments · Fixed by #12464
Closed

[Bug Report]docs : Inconsistent translation of examples incollapse #12463

RSS1102 opened this issue Nov 22, 2023 · 3 comments · Fixed by #12464

Comments

@RSS1102
Copy link
Contributor

RSS1102 commented Nov 22, 2023

重现链接

https://vant-ui.github.io/vant/#/en-US/collapse

Vant 版本

4.8.0

描述一下你遇到的问题。

The translation of the example in collapseis inconsistent, and I'm not sure if it needs to be modified.

重现步骤

image

image

设备/浏览器

No response

@chenjiahan
Copy link
Member

you can update that~ be consistent is better

@RSS1102
Copy link
Contributor Author

RSS1102 commented Nov 22, 2023

you can update that~ be consistent is better

I am happy to make it better.
I found that showDialog also has the same issue. Is it fixed on a new PR or this this PR?

There is this sample code on showDialog:

const beforeClose = (action) =>
  new Promise((resolve) => {
    setTimeout(() => {
      resolve(action === 'confirm');
    }, 1000);
  });
const beforeClose = (action) =>
 new Promise((resolve) => {
   setTimeout(() => {
     if (action === 'confirm') {
       resolve(true);
     } else {
       // 拦截取消操作
       resolve(false);
     }
   }, 1000);
 });

Their results are consistent, but which writing method should I follow?

@RSS1102
Copy link
Contributor Author

RSS1102 commented Nov 22, 2023

I will divide it into two submissions to facilitate the marking of ci tags(i think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants