Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Popup): create overlay for every popup #6357

Merged
merged 3 commits into from May 24, 2020

Conversation

chenjiahan
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

Merging #6357 into dev will increase coverage by 0.02%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6357      +/-   ##
==========================================
+ Coverage   91.23%   91.26%   +0.02%     
==========================================
  Files         171      171              
  Lines        4506     4510       +4     
  Branches      293      292       -1     
==========================================
+ Hits         4111     4116       +5     
- Misses        352      353       +1     
+ Partials       43       41       -2     
Impacted Files Coverage Δ
src/mixins/popup/overlay.ts 91.66% <89.47%> (+5.95%) ⬆️
src/mixins/popup/context.ts 100.00% <100.00%> (ø)
src/mixins/popup/index.js 100.00% <100.00%> (ø)
src/area/index.js 90.99% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f3979...060f489. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants