feat(ShareSheet): add className option #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6886 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 175 175
Lines 4720 4720
Branches 279 279
=======================================
Hits 4318 4318
Misses 368 368
Partials 34 34
Continue to review full report at Codecov.
|
chenjiahan
changed the title
chenjiahan
approved these changes
Jul 27, 2020
chenjiahan
reviewed
Jul 28, 2020
| wrapper.find('.van-share-sheet__option').element.className.indexOf('foo') > | ||
| -1 | ||
| ); | ||
| }); |
There was a problem hiding this comment.
const option = wrapper.find('.van-share-sheet__option').element;
expect(option.className.includes('foo')).toBeTruthy();
chenjiahan
approved these changes
Jul 28, 2020
chenjiahan
added a commit
that referenced
this pull request
Jul 29, 2020
* feat: van-share-sheet支持设置分享选项的类名 * Update README.zh-CN.md * Update README.md * Update index.vue * fix: 添加一些van-share-sheet测试用例 * fix: change van-share-sheet test code Co-authored-by: neverland <416417567@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
van-share-sheet支持设置分享选项的类名