Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Picker): add readonly prop #7105

Merged
merged 1 commit into from Sep 4, 2020

Conversation

chenjiahan
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

Merging #7105 into dev will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7105      +/-   ##
==========================================
+ Coverage   91.27%   91.31%   +0.04%     
==========================================
  Files         176      177       +1     
  Lines        4743     4757      +14     
  Branches      280      284       +4     
==========================================
+ Hits         4329     4344      +15     
+ Misses        378      377       -1     
  Partials       36       36              
Impacted Files Coverage Δ
src/icon/index.tsx 91.66% <ø> (ø)
src/picker/index.js 100.00% <ø> (ø)
src/picker/shared.ts 100.00% <ø> (ø)
src/field/index.js 99.47% <100.00%> (+<0.01%) ⬆️
src/form/index.js 100.00% <100.00%> (ø)
src/picker/PickerColumn.js 90.99% <100.00%> (+1.46%) ⬆️
src/tabbar/index.js 94.11% <100.00%> (+0.36%) ⬆️
src/tabs/index.js 81.08% <100.00%> (-1.42%) ⬇️
src/toast/index.js 98.50% <100.00%> (+0.02%) ⬆️
src/utils/interceptor.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3549a...1b24f68. Read the comment docs.

@chenjiahan chenjiahan merged commit 3cd200f into youzan:dev Sep 4, 2020
@chenjiahan chenjiahan deleted the picker_readonly_0905 branch September 4, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants