Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Swipe): leak when width has decimal #7562

Merged
merged 1 commit into from Nov 15, 2020

Conversation

chenjiahan
Copy link
Member

@github-actions
Copy link

github-actions bot commented Nov 15, 2020

🎊 PR Preview 5b4e063 has been successfully built and deployed to https://youzan-vant-preview-pr-7562.surge.sh

🕐 Build time: 81.648s

🤖 By surge-preview

@codecov-io
Copy link

Codecov Report

Merging #7562 (f712816) into 2.x (6569096) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #7562      +/-   ##
==========================================
+ Coverage   90.70%   90.78%   +0.07%     
==========================================
  Files         179      179              
  Lines        4908     4904       -4     
  Branches      297      295       -2     
==========================================
  Hits         4452     4452              
+ Misses        418      415       -3     
+ Partials       38       37       -1     
Impacted Files Coverage Δ
src/swipe/index.js 91.42% <100.00%> (ø)
src/utils/dom/scroll.ts 70.00% <0.00%> (+8.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6569096...f712816. Read the comment docs.

@chenjiahan chenjiahan merged commit 5b4e063 into youzan:2.x Nov 15, 2020
@chenjiahan chenjiahan deleted the swipe_decimal_1115 branch November 15, 2020 07:33
Fire-Dragons pushed a commit to Fire-Dragons/vant that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants