fix(Circle): the gradient color is incorrect #7909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 152b1eb has been successfully built and deployed to https://youzan-vant-preview-pr-7909.surge.sh 🕐 Build time: 115.699s
🤖 By surge-preview |
Codecov Report
@@ Coverage Diff @@
## dev #7909 +/- ##
=======================================
Coverage 77.79% 77.80%
=======================================
Files 144 144
Lines 5139 5140 +1
Branches 390 390
=======================================
+ Hits 3998 3999 +1
Misses 1083 1083
Partials 58 58
Continue to review full report at Codecov.
|
chenjiahan
approved these changes
Jan 15, 2021
|
👏👏 2.x 也可以提一个喔 |
John60676
commented
Jan 15, 2021
| @@ -110,7 +112,7 @@ export default createComponent({ | |||
| d={path.value} | |||
| style={style} | |||
| class={bem('hover')} | |||
| stroke={isObject(color) ? `url(#${id})` : color} | |||
| stroke={color} | |||
There was a problem hiding this comment.
@chenjiahan stroke={color} 这个属性应该可以去掉吧，内联里面有了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7905
2.x has the same problem, I can submit another PR if necessary