Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Swipe): re-initialize when popup reopened #8643

Merged
merged 1 commit into from May 1, 2021

Conversation

chenjiahan
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

Merging #8643 (4057cea) into dev (8db718d) will increase coverage by 0.09%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8643      +/-   ##
==========================================
+ Coverage   86.47%   86.57%   +0.09%     
==========================================
  Files         218      218              
  Lines        5435     5430       -5     
  Branches     1342     1342              
==========================================
+ Hits         4700     4701       +1     
+ Misses        464      458       -6     
  Partials      271      271              
Impacted Files Coverage Δ
src/swipe/Swipe.tsx 91.66% <90.90%> (+0.85%) ⬆️
src/composables/on-popup-reopen.ts 100.00% <0.00%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db718d...4057cea. Read the comment docs.

@chenjiahan chenjiahan merged commit c2b2e79 into youzan:dev May 1, 2021
@chenjiahan chenjiahan deleted the swipe_inside_popup_0501 branch May 1, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants