Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popover): add icon-prefix prop #8703

Merged
merged 2 commits into from May 17, 2021
Merged

feat(Popover): add icon-prefix prop #8703

merged 2 commits into from May 17, 2021

Conversation

lengkaixin
Copy link
Contributor

No description provided.

});

expect(wrapper.html()).toMatchSnapshot();
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个单测需要运行一下,把更新后的 snapshot 提交上来。

另外 show 属性是否要设置成 true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已添加已跑。

@chenjiahan chenjiahan changed the title fix: popover 增加 icon-prefix 属性 feat(Popover): add icon-prefix prop May 17, 2021
@chenjiahan chenjiahan merged commit 908210a into youzan:dev May 17, 2021
@chenjiahan
Copy link
Member

👍

@lengkaixin lengkaixin deleted the feature/popover_icon_prefix branch May 17, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants