Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Swipe): overflow lose efficacy in iOS safari #9933

Merged
merged 2 commits into from Nov 25, 2021

Conversation

chenjiangui
Copy link
Contributor

@chenjiangui chenjiangui commented Nov 24, 2021

issue #9931

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #9933 (d44da7a) into 2.x (cb6c10c) will not change coverage.
The diff coverage is n/a.

❗ Current head d44da7a differs from pull request most recent head 93b45b0. Consider uploading reports for the commit 93b45b0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              2.x    #9933   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files         184      184           
  Lines        5212     5212           
  Branches      307      307           
=======================================
  Hits         4724     4724           
  Misses        447      447           
  Partials       41       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6c10c...93b45b0. Read the comment docs.

@chenjiahan
Copy link
Member

有一个格式上的建议,可以把 issue #id 放在 PR 的描述里,而不是标题上哈

@chenjiangui
Copy link
Contributor Author

有一个格式上的建议,可以把 issue #id 放在 PR 的描述里,而不是标题上哈

好的🤓

@chenjiahan chenjiahan changed the title fix(Swipe): issue #9931 overflow lose efficacy in ios/safari fix(Swipe): overflow lose efficacy in iOS safari Nov 25, 2021
@chenjiahan chenjiahan merged commit 2890b77 into youzan:2.x Nov 25, 2021
@chenjiangui chenjiangui deleted the hotfix/swipe_20211124 branch November 25, 2021 02:54
@chenjiahan
Copy link
Member

@chenjiangui 麻烦往 dev 分支也提一下~

@chenjiangui
Copy link
Contributor Author

@chenjiangui 麻烦往 dev 分支也提一下~

补了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants