Drop udp packets from unknown hosts

[rtitmuss]

Check that incoming udp packets have been sent from the system
running nibegw, otherwise drop the packets.

[yozik04]

I used that hole during development as I was replaying UDP traffic to the lib. Now it is ok to fix =)

[rtitmuss]

Unfortunately this is a problem running in a Docker container in Hassio. In the docker container the source address for the UDP packet is on a virtual address (starting 172), see moby/libnetwork#1994.

This can be worked around by enabling host networking in the container (host_network: true in config.yaml), but that seems less secure. It might be better to revert this PR or make this configurable in some way. What do you think?

Longer term I might look at changing nibe_gw to support modbus_tcp, to remove the dependency on UDP.

[yozik04]

Ahh. I thought you have tested it already.
I required nibegw approach because I migrated from openhab. That was a smooth migration sensor by sensor. I was multiplexing udp packets to multiple ports.

[rtitmuss]

I had tested it locally, but not inside Hassio.

…

On Wed, 1 Jun 2022, 18:44 Jevgeni Kiski, ***@***.***> wrote: Ahh. I thought you have tested it already. I required nibegw approach because I migrated from openhab. That was a smooth migration sensor by sensor. I was multiplexing udp packets to multiple ports. — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGZOWRKAUPOWF5Z4C7QEFTVM6HPLANCNFSM5XOTFVMQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>