Skip to content

Commit

Permalink
Don’t run pylint as precommit hook because it is slow
Browse files Browse the repository at this point in the history
  • Loading branch information
ypid committed Mar 2, 2017
1 parent e034500 commit f4ecc8b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
12 changes: 11 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ remove-pre-commit-hook:
## }}}

## check {{{
.PHONY: check-quick
check-quick: check-unit-tests check-docs check-lint-quick

## Subset of `check`
.PHONY: check-precommit-hook
check-precommit-hook: check-unit-tests-with-coverage check-integration-tests check-docs check-lint-quick

.PHONY: check
check: check-unit-tests-with-coverage check-integration-tests check-docs check-lint

Expand All @@ -50,8 +57,11 @@ check-tox:
check-docs:
$(MAKE) "docs" > /dev/null

.PHONY: check-lint-quick
check-lint-quick: check-flake8 check-travis.yml

.PHONY: check-lint
check-lint: check-flake8 check-pylint check-pylint-tests check-travis.yml
check-lint: check-lint-quick check-pylint check-pylint-tests

.PHONY: check-flake8
check-flake8:
Expand Down
2 changes: 1 addition & 1 deletion dev/hooks/pre-commit
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/bash

make check
make check-precommit-hook

0 comments on commit f4ecc8b

Please sign in to comment.