Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names of actions conflict with translations elsewhere #40

Closed
interDist opened this issue Nov 23, 2017 · 1 comment
Closed

Names of actions conflict with translations elsewhere #40

interDist opened this issue Nov 23, 2017 · 1 comment
Labels
help wanted improvement

Comments

@interDist
Copy link
Contributor

interDist commented Nov 23, 2017 •
edited
Loading

I think the names of the actions (addition, deletion, change) should be marked for translation with context (pgettext_lazy), to avoid them being incorrectly translated. Mainly the word “change” is problematic, because it is ambiguous in English (can be either a verb or a noun).
@yprez
Copy link
Owner

yprez commented Dec 14, 2017

@interDist maybe you're right. I never knew about this problem with translations myself...

Would you mind submitting a pull request for this?

interDist added a commit to interDist/django-logentry-admin that referenced this issue Dec 29, 2017
@interDist
unifies translations and adds translation context (fixes yprez#39, yp…
a933f40 
…rez#40)
interDist added a commit to interDist/django-logentry-admin that referenced this issue Dec 29, 2017
@interDist
Unify translations and Add translation context (fixes yprez#39, yprez#40
b9540e8 
)
@yprez yprez closed this as completed in 3ab9e2a Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yprez @interDist