Skip to content

Commit

Permalink
Add a warning that the CMakeLists.txt is unmaintained.
Browse files Browse the repository at this point in the history
  • Loading branch information
@Yamagi
Yamagi committed Jul 23, 2021
1 parent 3e0af33 commit fb1a2b0
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
cmake_minimum_required(VERSION 3.0 FATAL_ERROR)

# Print a message that using the Makefiles is recommended.
message(NOTICE: " The CMakeLists.txt is unmaintained. Use the Makefile if possible.")

# Enforce "Debug" as standard build type.
if(NOT CMAKE_BUILD_TYPE)
set(CMAKE_BUILD_TYPE "Debug" CACHE STRING "Choose the type of build, options are: Debug Release RelWithDebInfo MinSizeRel." FORCE)
Expand Down

3 comments on commit fb1a2b0

@davll
Copy link

@davll davll commented on fb1a2b0 Jan 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the CMakeLists.txt unmaintained? Is it too difficult to structure the output files?
If so, I fixed the issue in my fork and I am open to share the idea with you

@Yamagi
Copy link
Member Author

@Yamagi Yamagi commented on fb1a2b0 Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because next to now one used it. It was broken several times by not porting changes from the Makefile and each time it took month until someone noticed. I wanted to remove it completely, but it turned out that there're some usecases for it. So it was marked as unmaintained. It should work for "normal" builds, though.

@davll
Copy link

@davll davll commented on fb1a2b0 Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree that it is awkward to keep the two build systems...
CMakeLists.txt is necessary for Windows builds with MSVC compiler coz it can generate Visual Studio solutions. So I keep the CMakeLists.txt in my fork instead.

Please sign in to comment.