New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Quake2 ReRelease #1040
Support Quake2 ReRelease #1040
Conversation
Looks like change is enough to run without critical errors. Known bugs in render code:
@Yamagi could you please review? |
Nice! I'll have a look soon. |
I will port lights fixes from yquake2/ref_vk#47 for maps when I will found way to fix light for models. I expect that it will be big change so for sure it will be a separate PR. |
I have added additional small fix for palette r_retexturing: use rgb with pcx if image has builtin palette. It resolved case when image is palette based but has different palette than default one: |
@Yamagi @DanielGibson What do you think about add Daikatana image format? It will take ~ 211 lines of code change. Look to https://github.com/0lvin/yquake2/tree/rerelease-combined as example. |
Moving home is done and I'm back in the game :) I will look into this into this in the next few days. |
Thank you, I have created one additional #1055. It's not finished. Code has only GL1 implementations, I have tested code with base1 and mguhub. It has no regression for old maps as I know. |
Use fullbright if not lights provided, same logic used by default for gl renders and way to show something for ReRelease version while real support is not implemented yet.
I have created a new repository for the remastered version: https://github.com/yquake2/yquake2remaster I think it's better to keep the remastered support in a fork until we either have developed it to a point were we can decide if it can be merged back into YQ2 itself or should stay a fork. This way we don't need to be too overcautious with breaking things. I have already merged this PR into the new repo. @0lvin, I'll give you write access to the new repository. |
Thank you! I will merge ref_vk to it also, just to have single source repository without additional branch in ref_vk for ReRelease with autorotate parameter in API. |
Fixed for support ReRelease path changes yquake2/yquake2remaster#3
Use PNG as replace of pcx automatically, generate colormap and 16to8 if information found(mostly required for soft render)
Rework of nolerp filtering, logic are same as for haptic feedback
Vulkan support yquake2/ref_vk#46