Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Quake2 ReRelease #1040

Closed
wants to merge 9 commits into from
Closed

Support Quake2 ReRelease #1040

wants to merge 9 commits into from

Conversation

0lvin
Copy link
Contributor

@0lvin 0lvin commented Aug 12, 2023

Fixed for support ReRelease path changes yquake2/yquake2remaster#3

Use PNG as replace of pcx automatically, generate colormap and 16to8 if information found(mostly required for soft render)

Rework of nolerp filtering, logic are same as for haptic feedback

Vulkan support yquake2/ref_vk#46

@0lvin 0lvin changed the title Support Quake2 ReRelease (not finished) Support Quake2 ReRelease Aug 13, 2023
@0lvin
Copy link
Contributor Author

0lvin commented Aug 13, 2023

Looks like change is enough to run without critical errors.

Known bugs in render code:

  • dark/no light in soft render
  • bright lighting in GL1/GL3/VK renders (looks like no shadows at all)
  • Slow rotating of sky

@Yamagi could you please review?

@Yamagi
Copy link
Member

Yamagi commented Aug 14, 2023

Nice! I'll have a look soon.

@0lvin
Copy link
Contributor Author

0lvin commented Aug 22, 2023

I will port lights fixes from yquake2/ref_vk#47 for maps when I will found way to fix light for models. I expect that it will be big change so for sure it will be a separate PR.

@0lvin
Copy link
Contributor Author

0lvin commented Aug 26, 2023

I have added additional small fix for palette r_retexturing: use rgb with pcx if image has builtin palette.

It resolved case when image is palette based but has different palette than default one:

Before with Daikatana colormap:
daikatana_colormap

Before with Quake2 colormap:
quake2_colormap

After fix:
reuse_colormap

@0lvin
Copy link
Contributor Author

0lvin commented Aug 26, 2023

@Yamagi @DanielGibson What do you think about add Daikatana image format? It will take ~ 211 lines of code change. Look to https://github.com/0lvin/yquake2/tree/rerelease-combined as example.

@Yamagi
Copy link
Member

Yamagi commented Sep 10, 2023

Moving home is done and I'm back in the game :) I will look into this into this in the next few days.

@0lvin
Copy link
Contributor Author

0lvin commented Sep 10, 2023

Thank you, I have created one additional #1055. It's not finished.

Code has only GL1 implementations, I have tested code with base1 and mguhub. It has no regression for old maps as I know.

@Yamagi
Copy link
Member

Yamagi commented Sep 16, 2023

I have created a new repository for the remastered version: https://github.com/yquake2/yquake2remaster I think it's better to keep the remastered support in a fork until we either have developed it to a point were we can decide if it can be merged back into YQ2 itself or should stay a fork. This way we don't need to be too overcautious with breaking things.

I have already merged this PR into the new repo. @0lvin, I'll give you write access to the new repository.

@Yamagi Yamagi closed this Sep 16, 2023
@0lvin
Copy link
Contributor Author

0lvin commented Sep 16, 2023

Thank you!

I will merge ref_vk to it also, just to have single source repository without additional branch in ref_vk for ReRelease with autorotate parameter in API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants