Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Problem: source code files don't have license references #13

Closed
yrashk opened this issue Apr 27, 2021 · 0 comments · Fixed by #32
Closed

Problem: source code files don't have license references #13

yrashk opened this issue Apr 27, 2021 · 0 comments · Fixed by #32

Comments

@yrashk
Copy link
Contributor

yrashk commented Apr 27, 2021

BSL license stipulates that every source file should have one:

All source files under BSL have a Change Date and the name of an Open Source license in the header. The Change Date specifies when the source file changes from BSL to the specified Open Source license. On the Change Date, or the fourth anniversary of the first publicly available distribution of the code under the BSL, whichever comes first, the code automatically becomes available under the Change License (i.e., an Open Source license).

Proposed solution: use an automatic header insertion tool and go-header lint (golangci-run includes it)
yrashk added a commit to yrashk/bpxe that referenced this issue May 14, 2021
@yrashk
BSL license stipulates that every source file should have one:
a5942ab 
> All source files under BSL have a Change Date and the name of an Open
Source license in the header. The Change Date specifies when the source
file changes from BSL to the specified Open Source license. On the
Change Date, or the fourth anniversary of the first publicly available
distribution of the code under the BSL, whichever comes first, the code
automatically becomes available under the Change License (i.e., an Open
Source license).

Solution: use an automatic header insertion tool (go-license)
and [go-header](https://github.com/denis-tingaikin/go-header) lint
(golangci-run includes it)

Closes yrashk-archived#13
yrashk added a commit to yrashk/bpxe that referenced this issue May 14, 2021
@yrashk
Problem: source code files don't have license references
985012e 
BSL license stipulates that every source file should have one:

> All source files under BSL have a Change Date and the name of an Open
Source license in the header. The Change Date specifies when the source
file changes from BSL to the specified Open Source license. On the
Change Date, or the fourth anniversary of the first publicly available
distribution of the code under the BSL, whichever comes first, the code
automatically becomes available under the Change License (i.e., an Open
Source license).

Solution: use an automatic header insertion tool (go-license)
and [go-header](https://github.com/denis-tingaikin/go-header) lint
(golangci-run includes it)

Originally, I wanted to have empty comment lines between clauses of the
license header (copyright, reference to LICENSE and Change Date clause),
but go-license and go-header didn't quite agree on how to handle empty
lines and go-header was complaining and failing the check. They did
agree when I used a block comment to insert the license, but `go vet`
didn't: golang/go#46169

So I just removed the empty comment lines to get this done for now.

Closes yrashk-archived#13
@yrashk yrashk mentioned this issue May 14, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: source code files don't have license references yrashk/bpxe
1 participant
@yrashk