Allowing multiple handlers through a hack #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by using dynamic atoms (a bad thing) based on the number of ports you have a connection on. A good design would have required a substantial rewrite of the application. However, to simply get things working in a decent way, although not perfect in terms of patterns, I decided to go this way. It is worth the time for an application in maintenance -- no technical debt on this one, unless someone else wants to take control.
This now works using gproc instead of list_to_atom. This is done using gproc and adds a dependency, warranting a version bump from 1 to 1.1
yrashk
added a commit
that referenced
this pull request
Mar 10, 2012
Allowing multiple handlers through a hack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by using dynamic atoms (a bad thing) based on
the number of ports you have a connection on.
A good design would have required a substantial rewrite of
the application. However, to simply get things working in
a decent way, although not perfect in terms of patterns,
I decided to go this way. It is worth the time for an
application in maintenance -- no technical debt on this
one, unless someone else wants to take control.