Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4.1 PG::SyntaxError: ERROR: syntax error at or near "as" #20

Closed
DazDotOne opened this issue Jul 2, 2014 · 4 comments
Closed

Rails 4.1 PG::SyntaxError: ERROR: syntax error at or near "as" #20

DazDotOne opened this issue Jul 2, 2014 · 4 comments

Comments

@DazDotOne
Copy link

As documented in O-I/pluck#10 and Casecommons/pg_search#167, there is an issue with will_paginate using the old .count() syntax.

Nazgum has made a branch that seems to have fixed will_paginate at https://github.com/nazgum/will_paginate.git

any chance this could be pulled in?

I've never done a pull request before but would be able to spare some time if you could give me instructions.

Thanks

@yrgoldteeth
Copy link
Owner

The .count() syntax is in the rubygems version of will_paginate still I'm guessing and I don't have any control of the upstream will_paginate code, this is just the view helpers to create Twitter Bootstrap particular HTML for the will_paginate views. Or, possibly, you've got an older version of will_paginate installed that meets the dependency for this particular gem.

I will check this against the pure will_paginate rubygem version later today, and if it's fixed upstream I'll look into locking the will_paginate dependency version to current.

@O-I
Copy link

O-I commented Jul 2, 2014

As far as I know, the commit necessary to fix this was merged into the master branch of will_paginate. However, there has been no new gem release.

@yrgoldteeth
Copy link
Owner

Ah, then yeah, I can't do anything about that, I just maintain the bootstrap-will_paginate gem and not the main will_paginate one.

@DazDotOne
Copy link
Author

Nice one guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants