Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons not highlighted when focused #21

Closed
practik opened this issue May 20, 2018 · 1 comment
Closed

buttons not highlighted when focused #21

practik opened this issue May 20, 2018 · 1 comment

Comments

@practik
Copy link

practik commented May 20, 2018

Steps to reproduce:

  1. Open the cookie manager window. The Domains list has focus.
  2. Press the Tab key repeatedly, moving focus through the various areas of the interface, until the Sub-domains checkbox beside the Search box is highlighted.
  3. Press the Tab key again.

Expected results: Some other part of the interface should be highlighted in some way to show the user where focus now is.
Actual results: For the next 10 presses of the Tab key, there is no visual indicator of focus anywhere in the window. Only on the 11th press does focus return to the Domains list.

By experimenting, I discovered that after the Sub-domains checkbox, focus moves through the 10 buttons at the bottom of the window. Three of those buttons delete cookies! A user could easily delete some or all of their cookies by accident as a result of this bug.

Cookie Quick Manager 0.2rc3 on Firefox 60.0.1 on macOS

@ysard
Copy link
Owner

ysard commented Jun 5, 2018

Hi, i see what you mean; the choice of the css class "btn-dark" for the buttons makes invisible the display change of during focus change.

The default class is much more explicit about this; examples here:
https://getbootstrap.com/docs/3.3/css/#buttons
https://www.w3schools.com/bootstrap/bootstrap_buttons.asp

For now, I keep the current class but I will add a dark border in the focus.

PS: Feel free to reopen this issue if satisfying

ysard added a commit that referenced this issue Jun 5, 2018
- tab key is now used to move from one element to another (instead of Ctrl+left/right)
- buttons have a border that indicates that they have the focus
@ysard ysard closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants