Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ".test" TLD rather than Google-owned ".dev" TLD. #68

Merged
merged 4 commits into from
Jan 8, 2018

Conversation

jacksonrayhamilton
Copy link
Contributor

Fixes #61. Pow decided to use ".test" so I figured we would do the same.

Of course, this will be a breaking change, but a welcome one.

@ysbaddaden
Copy link
Owner

This is out-of-sync with master.

I guess it's an acceptable solution. Prax doesn't care about the actual TLD anyway; it already accepts .test, .localhost or .whatever.you.want as long as they resolve to a local IP, so that just changes the default configured TLD.

I'll keep using .dev myself and damn Google.

@jacksonrayhamilton
Copy link
Contributor Author

Synchronized with master.

I suppose we can change the TLD by setting PRAX_DOMAINS? Maybe that should be documented, I see it in the code but not mentioned anywhere.

@ysbaddaden
Copy link
Owner

ysbaddaden commented Dec 12, 2017

Nope, the way we resolve hosts doesn't involve PRAX_DOMAINS anymore. Given myapp.some.where.localhost, for example, Prax will search, in order, for:

  1. myapp.some.where.localhost
  2. myapp.some.where
  3. myapp.some
  4. myapp

The TLD isn't of any importance; as long as a domain resolves to localhost, Prax will gladly accept it.

@ysbaddaden
Copy link
Owner

I didn't verify my claim, maybe it's skips the right-most TLD by default and thus searches for myapp.some.where initially. What's important is that the right-most TLDs can be whatever.

@jacksonrayhamilton
Copy link
Contributor Author

What's the best way to make the domains resolve to localhost? Update /etc/dnsmasq.d/prax manually and change "test" to one's TLD of choice?

@ysbaddaden
Copy link
Owner

Yes, for example. I copy-pasted test and localhost files myself, and left prax as is.

@jacksonrayhamilton
Copy link
Contributor Author

I added documentation explaining how to use Prax with other TLDs.

Is this good to merge?

@ysbaddaden
Copy link
Owner

Yup, thank you!

@ysbaddaden ysbaddaden merged commit 2b89e19 into ysbaddaden:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants