Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

Support the W3C Webdriver spec (?) #6

Closed
ysbaddaden opened this issue Aug 31, 2017 · 5 comments
Closed

Support the W3C Webdriver spec (?) #6

ysbaddaden opened this issue Aug 31, 2017 · 5 comments

Comments

@ysbaddaden
Copy link
Owner

ysbaddaden commented Aug 31, 2017

The original JsonWriteProtocol is now obsolete as of Selenium 3.5 and Firefox 55 (at least) and the client should be updated to the W3C Webdriver spec which introduces incompatibilities.

Sadly, the new protocol intermixes everything (driver, proxy, client, ...) and is missing many details about the actual protocol (e.g. what JSON is being transfered as a request and response body?) which makes it hard to follow, especially when compared to the very straightforward JsonWriteProtocol document. Sigh.

ysbaddaden added a commit that referenced this issue Aug 31, 2017
Fixes WebElement#initialize to support the W3C Webdriver return data
for finding elements, which is no longer a `{"ELEMENT": "IDENTIFIER"}`
but `{"element-UUID": "IDENTIFIER"}`.

There may be other differences between the protocols, but the test
suite is passing with this small change.

refs #6
@ysbaddaden
Copy link
Owner Author

The test suite is now passing with Selenium 3.5.3, Geckodriver 0.18.0 and Firefox 55.0.2.

I'm leaving this issue open, since there are probably other changes in the protocol.

@eliasjpr
Copy link

eliasjpr commented Sep 13, 2017

Just want to let you know that Chromedriver 2.32 and Selenium 3.5.3 worked for me

@ysbaddaden
Copy link
Owner Author

Thanks! I'll keep this open, as there may be some parts of the protocol that changed, but aren't covered by the very minimal test suite.

@eliasjpr
Copy link

Hey, I would like to talk to you about this project, we the core Amber team are making heavy use it to support system/feature tests. We are considering to make some changes to the driver to fit our needs. Find me on Gitter eliasjpr I would like to demo what we have so far.

@ysbaddaden
Copy link
Owner Author

It seems W3C Webdriver is correctly supported. Let's close.

@eliasjpr feel free to open issues detailing a few issues. I'll look at them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants