Skip to content

Commit

Permalink
Don't test MockServer's HTTP proxy of an HTTP/2 call (square#8325)
Browse files Browse the repository at this point in the history
This test is disabled, and it refers to a closed bug.
  • Loading branch information
swankjesse committed Apr 2, 2024
1 parent 79aa6fc commit 3cde79c
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions container-tests/src/test/java/okhttp3/containers/BasicProxyTest.kt
Expand Up @@ -15,7 +15,6 @@ import okhttp3.containers.BasicMockServerTest.Companion.MOCKSERVER_IMAGE
import okhttp3.containers.BasicMockServerTest.Companion.trustMockServer
import okio.buffer
import okio.source
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
import org.mockserver.client.MockServerClient
import org.mockserver.configuration.Configuration
Expand Down Expand Up @@ -107,27 +106,6 @@ class BasicProxyTest {
}
}

@Test
@Disabled("https://github.com/square/okhttp/issues/8233")
fun testOkHttpSecureProxiedHttp2() {
testRequest {
val client =
OkHttpClient.Builder()
.trustMockServer()
.proxy(Proxy(Proxy.Type.HTTP, it.remoteAddress()))
.protocols(listOf(Protocol.HTTP_2, Protocol.HTTP_1_1))
.build()

val response =
client.newCall(
Request((mockServer.secureEndpoint + "/person?name=peter").toHttpUrl()),
).execute()

assertThat(response.body.string()).contains("Peter the person")
assertThat(response.protocol).isEqualTo(Protocol.HTTP_2)
}
}

@Test
fun testUrlConnectionDirect() {
testRequest {
Expand Down

0 comments on commit 3cde79c

Please sign in to comment.