Fix restoring library elements that have more than one folder #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple folders are present on a library element (e.g. if used in multiple dashboards in different folders), the API returns multiple folder ID responses. Handle that by recreating the element with the first folder. Also, switch from using folderId to folderUid (folderId has been deprecated since grafana v9).
|
Hi @antifuchs thanks for the PR What do you mean by that "re-format the file with Thank you |
ysde
reviewed
Mar 5, 2023
| folder_id_response = get_folder( | ||
| folder_uid, grafana_url, http_post_headers, verify_ssl, client_cert, debug | ||
| )[1] | ||
| if isinstance(folder_id_response, list): |
There was a problem hiding this comment.
Should we also test len(folder_id_response) here ?
There was a problem hiding this comment.
Hm, I don't think so: there is always at least one, probably more than one in the array case.
I don't know what to do if the grafana API started returning arrays that didn't contain any folders at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple folders are present on a library element (e.g. if used in multiple dashboards in different folders), the API returns multiple folder ID responses. Handle that by recreating the element with the first folder.
Also, switch from using folderId to folderUid (folderId has been deprecated since grafana v9).
I unfortunately couldn't get my editor to not re-format the file with
blackin the hurry I was in today. If this is undesired, let me know and I'll fix it later.