Update alert-rules key to match convention set in cli.py #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/ysde/grafana-backup-tool/blob/master/grafana_backup/cli.py#L27-L28 Current behavior requires passing in save_alert_rules (or save-alert-rules) which is counter the established pattern and counter the documentation of components in cli.py
|
I could add another key:value pair for |
I 'd prefer to just make it consistent since this is a brand new feature; I should have been more critical on the naming but I missed it... |
|
Thank you @relaytheurgency ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ysde/grafana-backup-tool/blob/master/grafana_backup/cli.py#L27-L28
Current behavior requires passing in save_alert_rules (or save-alert-rules) which is counter the established pattern and counter the documentation of components in cli.py