hide_version-config: add version as config/env var #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase @chriz-active |
- within the grafana-config the version can be hidden - as a fall back the version can be provided - in the config-file - as environment variable Fixes: ysde#225
- to address review comment by @acjohnson
chriz-active
force-pushed
the
feature-hide-version
branch
from
7a908c1
to
b0f512a
Compare
|
@acjohnson rebased wrt. master |
|
Thank you @chriz-active 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
within the grafana-config the version can be hidden
Fixes: #225
Note: I messed up our branch and by fixing it, github decided to close the original pull request: #226
Sorry for that.