Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Legend is wrong on GUI (off by one) once the scale is at or above 1s #68

Closed
rationalcoder opened this issue Sep 15, 2017 · 5 comments
Closed

Time Legend is wrong on GUI (off by one) once the scale is at or above 1s #68

rationalcoder opened this issue Sep 15, 2017 · 5 comments
Assignees
@cas4ey
Labels
bug resolved ui Issues related to profiler_gui
Milestone
Release v1.3.0

Comments

@rationalcoder
Copy link
Contributor

issue22-1
issue22-2
issue22-3
issue22-4
@cas4ey cas4ey added the bug label Sep 18, 2017
@cas4ey cas4ey self-assigned this Sep 18, 2017
cas4ey added a commit that referenced this issue Sep 29, 2017
@cas4ey
#68 fixed [GUI] scaling marker round problems
a3ba063
@cas4ey
Copy link
Collaborator

cas4ey commented Sep 29, 2017

@rationalcoder Can you please test this commit?

@rationalcoder
Copy link
Contributor Author

@cas4ey I don't know if there is a formal github review thing I can do, but I can confirm that this works for me.

@rationalcoder rationalcoder reopened this Sep 29, 2017
@rationalcoder
Copy link
Contributor Author

@cas4ey Not sure if closing this myself is the right thing to do, so I am going to let you do it when you are ready.

@cas4ey cas4ey closed this as completed Sep 29, 2017
@cas4ey
Copy link
Collaborator

cas4ey commented Sep 29, 2017

@rationalcoder You are the author and reviewer so why not :)

@rationalcoder
Copy link
Contributor Author

@cas4ey Just making sure. I will close it myself from now on.

@cas4ey cas4ey added this to the Release v1.3.0 milestone Oct 12, 2017
@cas4ey cas4ey added the ui Issues related to profiler_gui label May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cas4ey cas4ey

Labels
bug resolved ui Issues related to profiler_gui
Projects
None yet
Milestone
Release v1.3.0
Development

No branches or pull requests
2 participants
@cas4ey @rationalcoder